Skip to content

fix: scroll issue after scrolling and selecting elements #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: scroll issue after scrolling and selecting elements #115

wants to merge 1 commit into from

Conversation

@smit95tpatel
Copy link

@smit95tpatel smit95tpatel commented May 5, 2023

Description

  • Situation arises when there is an already selected option, and user scrolls further away from the selected option in the options dropdown list, then when the user selects a different option, the selected option is not getting updated.
  • This PR fixes it by removing componentWillRecieveProps as it getting called every time when user selects an option.
  • Have also updated component to PureComponent for optimisation.
  • Attaching video for reference

Video reference

Screen.Recording.2023-05-05.at.10.06.08.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@smit95tpatel